Ok/no repo2 plus #2664
Closed
Ok/no repo2 plus #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it sample_font.ttf changed in AOSP, and we would have to adapt test for it
@JvmSuppressWildcards isn't in the expect, and not in jb-main
``` > Task :lifecycle:lifecycle-runtime:compileTestKotlinWasmJs FAILED e: file:///D:/Work/2/compose-multiplatform-core/lifecycle/lifecycle-runtime/src/wasmJsTest/kotlin/androidx/lifecycle/runLifecycleTest.wasmJs.kt:24:5 Return type mismatch: expected 'JsPromiseInterfaceForTesting', actual 'Promise<JsAny?>'. e: file:///D:/Work/2/compose-multiplatform-core/lifecycle/lifecycle-runtime/src/webTest/kotlin/androidx/lifecycle/runLifecycleTest.web.kt:23:8 Conflicting overloads: actual fun runLifecycleTest(block: suspend CoroutineScope.() -> Unit): JsPromiseInterfaceForTesting ``` - runLifecycleTest.wasmJs.kt was added in `integration` - but isn't compilable - jb-main doesn't use this file
Only Android is supported by new AGP
To avoid combining multiple changes Plan: - merge to jb-main - sync dependencies with AOSP in jb-main(TODO create task)
eymar
force-pushed
the
ok/no-repo2-plus
branch
9 times, most recently
from
08783c1 to
f1759b5
Compare
eymar
force-pushed
the
ok/no-repo2-plus
branch
from
feb6c9f to
580d181
Compare
MatkovIvan
force-pushed
the
integration-no-repo
branch
from
1bd5d22 to
eaa6712
Compare
Member
Author
|
Closing this. The workaround-commit has been cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to investigate flaky web tests
Testing
N/A
Release Notes
N/A